From 26f955f196a608928b96651b7ff1c2a4b9998d95 Mon Sep 17 00:00:00 2001
From: handreas <andreas.hamacher@monash.edu>
Date: Wed, 22 Apr 2020 11:49:08 +0000
Subject: [PATCH] reducing unnecessary changed reports on ansible
Former-commit-id: 8e66601fa87fe04e782741dcd871d3a599ed033c
---
roles/extra_packages/tasks/main.yml | 4 ++++
roles/gpu/tasks/main.yml | 12 +++---------
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/roles/extra_packages/tasks/main.yml b/roles/extra_packages/tasks/main.yml
index 89b03b15..8410de7f 100644
--- a/roles/extra_packages/tasks/main.yml
+++ b/roles/extra_packages/tasks/main.yml
@@ -8,12 +8,16 @@
become: true
become_user: root
when: ansible_os_family == 'RedHat'
+ changed_when: false
+
- name: "Clear yum pending transactions"
command: yum-complete-transaction --cleanup-only
become: true
become_user: root
+ register: yumCompleteTransactioncall
when: ansible_os_family == 'RedHat'
+ changed_when: '"No unfinished transactions left." not in yumCompleteTransactioncall.stdout'
- name: "Install extra packages"
yum: "name={{ item }} exclude={{ excludes|join(',') }} update_cache=yes state=present"
diff --git a/roles/gpu/tasks/main.yml b/roles/gpu/tasks/main.yml
index 96425d40..72af3a7b 100644
--- a/roles/gpu/tasks/main.yml
+++ b/roles/gpu/tasks/main.yml
@@ -25,6 +25,7 @@
- xorg-x11-xauth
- xorg-x11-proto-devel
- xorg-x11-xkb-utils
+ - python-jinja2
when: ansible_os_family == 'RedHat'
- name: install deps
@@ -41,6 +42,8 @@
- 'libglvnd-dev'
- 'xserver-xorg'
- 'vim'
+ - 'python-jinja2'
+ - 'python3-jinja2'
state: present
update_cache: yes
become: true
@@ -213,15 +216,6 @@
# become: true
# become_user: root
# when: template_xorgconf is defined and template_xorgcon
-- name: install dependencies for nvidia-xconf-gen
- apt:
- name:
- - python-jinja2
- - python3-jinja2
- update_cache: yes
- state: present
- become: true
- become_user: root
- name: run nvidia-xconf-gen
script: scripts/nvidia-xconf-gen.py
--
GitLab