From f662d715c5293fd8cd4fe248728276cbbd6e7e4d Mon Sep 17 00:00:00 2001
From: Simon Michnowicz <simon.michnowicz@monash.edu>
Date: Mon, 14 Jan 2019 14:38:57 +1100
Subject: [PATCH] improved name for NHC_NAT_CHK_EXTERNAL_IP_ADDRESS

Former-commit-id: 2c67e5d4d4879a814f65bbe0575bd327cabcc7c2
---
 roles/nhc/README.md                  | 4 +++-
 roles/nhc/templates/check_nat.nhc.j2 | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/roles/nhc/README.md b/roles/nhc/README.md
index 4f7ecf61..37b6ea18 100644
--- a/roles/nhc/README.md
+++ b/roles/nhc/README.md
@@ -12,7 +12,9 @@ nhc_emails: nobody@nowhere.nowhere
 nhc_email_subject: "Node Health Check" 
 
 In addition the NAT check needs two variables to be defined to be enabled  (See example)
+- ADD_NHC_NAT_CHECK has to be defined to (any) value
+- NHC_NAT_CHK_EXTERNAL_IP_ADDRESS is the address to be pinged
 
 Example:
   roles:
-  - { role: nhc, EXTERNAL_IP_ADDRESS: "118.138.246.208", ADD_NHC_NAT_CHECK: 1  }
+  - { role: nhc, NHC_NAT_CHK_EXTERNAL_IP_ADDRESS: "118.138.246.208", ADD_NHC_NAT_CHECK: 1  }
diff --git a/roles/nhc/templates/check_nat.nhc.j2 b/roles/nhc/templates/check_nat.nhc.j2
index 8f64e3aa..ab56e57e 100644
--- a/roles/nhc/templates/check_nat.nhc.j2
+++ b/roles/nhc/templates/check_nat.nhc.j2
@@ -7,7 +7,7 @@ function check_nat() {
 
 
 #test NAT by pinging an external IP ADDRESS
-PING_EXTERNAL="ping -c 2 {{ EXTERNAL_IP_ADDRESS }}"
+PING_EXTERNAL="ping -c 2 {{ NHC_NAT_CHK_EXTERNAL_IP_ADDRESS }}"
  
 $PING_EXTERNAL
 RESULT=$?
-- 
GitLab