clean up

roles/OpenVPN-Server/meta/main.yml

 ---
 dependencies:
-  - { role: easy-rsa-CA }
   - { role: easy-rsa-certificate, x509_csr_args: "--server" }

roles/easy-rsa-certificate/tasks/buildCert.yml

@@ -47,8 +47,6 @@
 
 - name: "Creating CSR"
   shell: " cd /etc/easy-rsa/2.0; . ./vars; export EASY_RSA=\"${EASY_RSA:-.}\"; \"$EASY_RSA\"/pkitool --csr {{ x509_csr_args }} {{ x509_common_name }}"
-#  args:
-#    creates: "/etc/easy-rsa/2.0/keys/{{ x509_common_name }}.key"
   when: needcert
   sudo: true
 
@@ -64,23 +62,14 @@
 - name: "Copy CSR to CA"
   remote_user: "{{ hostvars[x509_ca_server]['ansible_ssh_user'] }}"
   delegate_to: "{{ x509_ca_server }}"
-#  copy: "src=/tmp/{{ inventory_hostname }}/{{ inventory_hostname }}.csr dest=/tmp/{{ inventory_hostname }}.csr force=yes"
   copy: "src=/tmp/{{ inventory_hostname }}/{{ inventory_hostname }}.csr dest=/etc/easy-rsa/2.0/keys/{{ x509_common_name }}.csr force=yes"
   when: needcert
   sudo: true
 
-#- name: "Place CSR to a right place"
-#  local_action: "command cp -f /tmp/{{ inventory_hostname }}.csr /etc/easy-rsa/2.0/keys/{{ x509_common_name }}.csr"
-#  when: needcert
-#  sudo: true
-
 - name: "Sign Certificate"
   remote_user: "{{ hostvars[x509_ca_server]['ansible_ssh_user'] }}"
   delegate_to: "{{ x509_ca_server }}"
   shell:    "cd /etc/easy-rsa/2.0; . ./vars; export EASY_RSA=\"${EASY_RSA:-.}\" ;\"$EASY_RSA\"/pkitool --sign {{ x509_sign_args }} {{ x509_common_name }}"
-#  args:
-#    chdir: "/etc/easy-rsa/2.0"
-#    creates: "/etc/easy-rsa/2.0/keys/{{ x509_common_name }}.crt"
   when: needcert
   sudo: true
 
@@ -103,7 +92,6 @@
   sudo: true
 
 - name: "Copy the certificate to the node"
-#  copy: "src=/tmp/{{ x509_common_name }}.crt dest={{ x509_cert_file }} force=yes"
   copy: "src=/tmp/{{ inventory_hostname }}/{{ x509_common_name }}.crt dest=/tmp/{{ x509_common_name }}.crt force=yes"
   sudo: true
   when: needcert

roles/etcHosts/defaults/main.yml

----
-get_groups: true
-edit_hosts: true

roles/etcHosts/tasks/main.yml

@@ -2,14 +2,12 @@
   template: dest=/tmp/groups src=groups.j2
   run_once: True
   delegate_to: 127.0.0.1
-  when: get_groups
 
 - name: make hosts data
   command: ./scripts/makehosts.py /tmp/groups {{ domain }}
   delegate_to: 127.0.0.1
   run_once: True
   register: hosts_data
-  when: edit_hosts
                
 - name: write hosts file
   lineinfile:
@@ -19,4 +17,3 @@
     state: present
   sudo: true
   with_items: hosts_data.stdout_lines
-  when: edit_hosts

roles/slurm-build/tasks/main.yml

@@ -39,7 +39,6 @@
   shell: rpm -i /root/rpmbuild/RPMS/x86_64/munge-libs-{{ munge_version }}-1.el6.x86_64.rpm /root/rpmbuild/RPMS/x86_64/munge-{{ munge_version }}-1.el6.x86_64.rpm /root/rpmbuild/RPMS/x86_64/munge-devel-{{ munge_version }}-1.el6.x86_64.rpm
   sudo: true
   when: munge_installed.stdout.find("munge") == -1 
-#  when: munge_installed is failed or munge_installed.stdout.find("munge") == -1 
 
 - name: make slurm rpms
   shell: rpmbuild -ta --clean slurm-{{ slurm_version }}.tar.bz2

roles/syncExports/templates/exports.j2

+{% set iplist = [] %}
 {% for export in exportList %}
-{{ export.src }} {% for group in groupList %}{% for node in groups[group.name] %} {{ hostvars[node]['ansible_'+group.interface]['ipv4']['address'] }}({{ export.srvopts }}) 
-{% endfor %}
+{% for group in groupList %}
+{% for node in groups[group.name] %}
+{% if hostvars[node]['ansible_'+group.interface] is defined %}
+{% if iplist.append(hostvars[node]['ansible_'+group.interface]['ipv4']['address']) %}
+{% endif %}
+{% endif %}
 {% endfor %}
 {% endfor %}
+{{ export.src }} {% for ip in iplist|unique %}{{ ip }}({{ export.srvopts }}) {% endfor %}
 
+{% endfor %}