reducing the number of unnecessary changed reports from ansible

Former-commit-id: 7e7d77ab

.gitlab-ci.yml

@@ -86,7 +86,7 @@ build_cluster_cicd:
     - source ./$NECTAR_ALLOCATION-openrc.sh
     - openstack stack list
     - bash -x ./heat/heatcicdwrapper.sh create_or_update $STACKNAME
-    - bash -x ./heat/server_rebuild.sh all
+    - bash -x ./heat/server_rebuild.sh ComputeNodes
   after_script:
     - sleep 30 # artifically wait a bit to give the nodes time to boot
 #  only:
@@ -114,7 +114,7 @@ ansible_create_cluster_stage:
     - ansible -i files/inventory.$STACKNAME --key-file ../gc_key.pem -b -a "systemctl restart slurmdbd" ManagementNodes
     - sleep 60
     - echo do it again
-    - ANSIBLE_STDOUT_CALLBACK=json ansible-playbook -i files/inventory.$STACKNAME --key-file ../gc_key.pem --skip-tags monitoring master_playbook.yml --limit ComputeNodes > computenodes_log.json
+    - ansible-playbook -i files/inventory.$STACKNAME --key-file ../gc_key.pem --skip-tags monitoring master_playbook.yml --limit ComputeNodes
     
 
 tests:

CICD/plays/computenodes.yml

 
 - hosts: 'DesktopNodes,ComputeNodes,LoginNodes,VisNodes'
+  gather_facts: True
   vars_files: 
   - vars/passwords.yml 
   - vars/names.yml
@@ -12,6 +13,7 @@
   tags: [ always ]
 
 - hosts: 'DesktopNodes,ComputeNodes,LoginNodes'
+  gather_facts: False
   vars_files: 
   - vars/passwords.yml 
   - vars/names.yml
@@ -30,17 +32,14 @@
   - { role: set_semaphore_count, tags: [ semaphore ] }
 
 - hosts: 'VisNodes'
+  gather_facts: False
   vars_files:
-  - vars/passwords.yml
-  - vars/names.yml
-  - vars/ldapConfig.yml
-  - vars/filesystems.yml
-  - vars/slurm.yml
   - vars/vars.yml
   roles:
   - { role: gpu, tags: [ gpu ] }
 
 - hosts: 'DesktopNodes,ComputeNodes,LoginNodes'
+  gather_facts: False
   vars_files:
   - vars/passwords.yml
   - vars/names.yml
@@ -52,6 +51,7 @@
   - { role: slurm_config, tags: [slurm, slurm_config] }
 
 - hosts: 'DesktopNodes,ComputeNodes'
+  gather_facts: False
   vars_files:
   - vars/passwords.yml
   - vars/names.yml

roles/config_repos/tasks/main.yml

 ---
 
-- name: make sure out repo server is resolvable
+- name: make sure our repo server is resolvable
   lineinfile:
-    dest: /etc/hosts
-    line: "{{ reposerverip }} {{ reposervername }}"  #this is duplicated in the role calculateEtcHosts
+    path: /etc/hosts
+    line: "{{ reposerverip }} {{ reposervername }}"
     owner: root
     group: root
   become: True 

roles/nfs-client/tasks/main.yml

 ---
 - name: install dependencies
-  yum: name={{ item }} state=installed
+  package:
+    name:
+      - libnfsidmap 
+      - nfs-utils
+      - nfstest.noarch
+    state: installed
   become: true
-  with_items:
-    - libnfsidmap 
-    - nfs-utils
-    - nfstest.noarch
   when: ansible_os_family == "RedHat" and ansible_distribution_major_version == "7"
 
 - name: install dependencies
-  yum: name={{ item }} state=installed
+  package:
+    name:
+      - nfs-utils-lib
+    state: installed
   become: true
-  with_items:
-    - nfs-utils-lib
   when: ansible_os_family == "RedHat" and ansible_distribution_major_version < "7"
 
 - name: install dependencies nfs-common ubuntu

roles/nfs-common/tasks/aptPackages.yml

 ---
-- 
-  name: "Install nfs-utils"
-  with_items:
-    - nfs-common
-    - nfs-kernel-server
-  apt: "name={{ item }} state=present"
+- name: "Install nfs-utils"
+  package:
+    name:
+      - nfs-common
+      - nfs-kernel-server
+    state: present
   become: true

roles/nfs-common/tasks/yumPackages.yml

 --- 
-- 
-  name: "Install nfs-utils"
-  with_items: 
-    - bind-utils
-    - nfs-utils
-  yum: "name={{ item }} state=present"
+- name: "Install nfs-utils"
+  package:
+    name: 
+      - bind-utils
+      - nfs-utils
+    state: present
   become: true