reducing the number of changes

CICD/plays/computenodes.yml

@@ -27,6 +27,7 @@
   - { role: lmod, tags: [ other ] }
   - { role: enable_modules, default_modules: "modulecmd", tags: [ other ] }
   - { role: postfix, tags: [ mail, other ] }
+  - { role: set_semaphore_count, tags: [ semaphore ] }
 
 - hosts: 'VisNodes'
   vars_files:

roles/calculateEtcHosts/files/makehosts.py

@@ -23,7 +23,7 @@ for group in d['groups'].keys():
       else:
         hosts[h] = ['%s.%s %s'%(name,domain,name)]
 
-for h in hosts.keys():
+for h in sorted(hosts.keys()):
     if d['hostvars'].has_key(h):
 	for addr in d['hostvars'][h]['ansible_all_ipv4_addresses']:
 	    if "172.16.200" in addr:
@@ -32,14 +32,14 @@ for h in hosts.keys():
 		    string=string+" %s"%(name)
 		print string
 
-for h in hosts.keys():
+for h in sorted(hosts.keys()):
     if d['hostvars'].has_key(h):
         string="%s"%(d['hostvars'][h]['ansible_default_ipv4']['address'])
         for name in hosts[h]:
             string=string+" %s"%(name)
         print string
 
-for h in hosts.keys():
+for h in sorted(hosts.keys()):
     if d['hostvars'].has_key(h):
         if d['hostvars'][h].has_key('ansible_tun0'):
             string="%s"%(d['hostvars'][h]['ansible_tun0']['ipv4']['address'])

roles/set_semaphore_count/tasks/main.yml

 ---
 - name: set the value of the Semaphores
   set_fact:
-       SEM_COUNT: "500 256000 64 10240"
+       SEM_COUNT: "500\t256000\t64\t10240"
   when: SEM_COUNT is not defined
 - name: test value
   debug: msg="Value of semaphores is {{ SEM_COUNT }} "  #"
@@ -16,6 +16,7 @@
      mode: "u+rwx,o=rx,g=rx"
   become: true
   become_user: root
+  when: ansible_os_family == 'RedHat'
      
 - name: Place comment line in file
   lineinfile: 
@@ -24,6 +25,7 @@
      state: present
   become: true
   become_user: root
+  when: ansible_os_family == 'RedHat'
 
 - name: Place comment line in file
   lineinfile: 
@@ -36,9 +38,21 @@
      mode: "u+rwx,o=rx,g=rx"
   become: true
   become_user: root
+  when: ansible_os_family == 'RedHat'
+
+- name: get current value
+  command: cat /proc/sys/kernel/sem
+  register: current_sem
+  changed_when: current_sem.stdout not in "{{ SEM_COUNT }}"
+
+- debug:
+    var: current_sem
 
 - name: set semaphore count now 
   shell: "/usr/bin/echo {{ SEM_COUNT }}   > /proc/sys/kernel/sem"
   become: true
   become_user: root
+  when: 
+  - current_sem.changed
+  - ansible_os_family == 'RedHat'
 

roles/set_timezone/tasks/main.yml

@@ -3,12 +3,15 @@
   template: src=ntp.conf.j2 dest=/etc/ntp.conf mode=644 owner=root group=root
   become: true
   become_user: root
+  register: ntpinstall
 
 - name: restart ntpd redhat
   service: name=ntpd state=restarted 
   become: true
   become_user: root
-  when: ansible_os_family == "RedHat"
+  when: 
+    - ansible_os_family == "RedHat"
+    - ntpinstall.changed
 
 - name: ensure ntpd is enabled and started redhat
   service: name=ntpd state=started enabled=yes   
@@ -20,7 +23,9 @@
   service: name=ntp state=restarted 
   become: true
   become_user: root
-  when: ansible_os_family == "Debian"
+  when: 
+    - ansible_os_family == "Debian"
+    - ntpinstall.changed
 
 - name: ensure ntpd is enabled and started ubuntu
   service: name=ntp state=started enabled=yes   

roles/upgrade/tasks/main.yml

@@ -28,6 +28,8 @@
   become: true
   become_user: root
   when: ansible_os_family == 'RedHat'
+  register: yumtransactioncleanup
+  changed_when: "'No unfinished transactions left.' not in yumtransactioncleanup.stdout"
 
 - name: yum upgrade
   yum: name=* state=latest