• Tom Scogland's avatar
    add mypy to style checks; rename `spack flake8` to `spack style` (#20384) · 857749a9
    Tom Scogland authored
    I lost my mind a bit after getting the completion stuff working and
    decided to get Mypy working for spack as well. This adds a 
    `.mypy.ini` that checks all of the spack and llnl modules, though
    not yet packages, and fixes all of the identified missing types and
    type issues for the spack library.
    In addition to these changes, this includes:
    * rename `spack flake8` to `spack style`
    Aliases flake8 to style, and just runs flake8 as before, but with
    a warning.  The style command runs both `flake8` and `mypy`,
    in sequence. Added --no-<tool> options to turn off one or the
    other, they are on by default.  Fixed two issues caught by the tools.
    * stub typing module for python2.x
    We don't support typing in Spack for python 2.x. To allow 2.x to
    support `import typing` and `from typing import ...` without a
    try/except dance to support old versions, this adds a stub module
    *just* for python 2.x.  Doing it this way means we can only reliably
    use all type hints in python3.7+, and mypi.ini has been updated to
    reflect that.
    * add non-default black check to spack style
    This is a first step to requiring black.  It doesn't enforce it by
    default, but it will check it if requested.  Currently enforcing the
    line length of 79 since that's what flake8 requires, but it's a bit odd
    for a black formatted project to be quite that narrow.  All settings are
    in the style command since spack has no pyproject.toml and I don't
    want to add one until more discussion happens. Also re-format
    `style.py` since it no longer passed the black style check
    with the new length.
    * use style check in github action
    Update the style and docs action to use `spack style`, adding in mypy
    and black to the action even if it isn't running black right now.