Skip to content
Snippets Groups Projects

Dev

Merged Dev
dev into test
1 unresolved thread
Merged Chris Hines requested to merge dev into test
1 unresolved thread

Lots of teeny tiny commits. Please just look at the changes rather than the indivial commits.

Overall it tightens the logic on getting the control master socket open and uses ServerAlive options to avoid anythign being squashed by firewalls.

I'm not sure if this will produce stability improvements on those issues I can't reproduce reliably

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Dockerfile
1 1 FROM ubuntu
2 2 WORKDIR /opt/strudel2/src
3 3 COPY . /opt/strudel2/src
4 RUN apt update
5 RUN apt install -y python3 gcc python3-pip
6 RUN apt install -y openssh-client
7 RUN pip3 install -r requirements.txt
8 RUN python3 ./setup.py install
4 RUN apt update && apt install -y python3 gcc python3-pip openssh-client
  • Lance Wilson
    Lance Wilson @lancew ·

    I'm not keen on this combination of commands. My preference is split defined commands.

  • Chris Hines
    Chris Hines @chines ·
    Author Owner

    mmm, so the reason to combine them is to build a single docker image "layer". It turns out each instance of RUN creates ANOTHER layer in the image, so minimising the RUN commands (into sane chunks) is a good idea

  • Please register or sign in to reply
  • Lance Wilson merged

    merged

  • Lance Wilson mentioned in commit d5a7c624

    mentioned in commit d5a7c624

    • Please register or sign in to reply